Feature/1.x/13 publication landing frontend #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o optional and added per-theme variants. Removed uuids and config hashes. Hid banner from content on publication landing pages.
…ng-frontend' into feature/1.x/13-publication-landing-frontend
|
@justinepocock wants to do a little more work on this before merging 😄 |
|
@justinepocock @rupertj where are we at with this one? |
|
Here feels about right: https://media.giphy.com/media/Z9ErMP3gYYlcAadEGd/giphy.gif |
|
Waiting for these : |
|
@justinepocock @rupertj need any help here Nearly ready to merge this one? |
|
Let's just get this merged, the only thing outstanding really is the svg for excel files which for some reason is proving more tricky than expected. It feels like a very small thing to be blocking this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.