Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placed menu block for subsites by default. #19

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

rupertj
Copy link
Member

@rupertj rupertj commented May 29, 2024

Implements #13.

NB that this uses the default block placement mechanism from localgovdrupal/localgov_core#212.

I've been testing this PR with this line in composer to use that version of localgov_core:

"localgovdrupal/localgov_core": "dev-feature/2.x/211-installing-blocks as 2.13.2",

@finnlewis
Copy link
Member

Hey @rupertj

Just looking at this one alongside localgovdrupal/localgov_core#212

Tried this :

  1. fresh install of localgov profile
  2. enable the localgov_subsites_extras
  3. look for the Subsites menu at admin/structure/block
  4. Not seeing it

I note that localgov_subsites_extras does not seem to depend on localgov_subsites. Is that by design?

@finnlewis
Copy link
Member

Tested like this:

Fresh install of LocalGov Drupal codebase.

ddev composer require "localgovdrupal/localgov_core:dev-feature/2.x/211-installing-blocks as 2.13.2" -W
ddev composer require "localgovdrupal/localgov_subsites_extras:dev-feature/1.x/13-place-menu-block as 1.0.0-alpha1" -W
ddev drush si localgov -y; 
ddev drush en localgov_subsites_extras -y; 
ddev drush uli;

Then checked that the "Subsiites menu" block is placed in the "Subsites menu" region, which it is now!

Thanks @rupertj - this part of it seems to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants