Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastianbergmann committed Sep 27, 2023
1 parent 3a7bc7f commit ccb711a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
1 change: 1 addition & 0 deletions ChangeLog-10.4.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ All notable changes of the PHPUnit 10.4 release series are documented in this fi
* [#5515](https://github.com/sebastianbergmann/phpunit/issues/5515): The `Test\AssertionSucceeded` and `Test\AssertionFailed` events are always emitted again
* [#5515](https://github.com/sebastianbergmann/phpunit/issues/5515): `--log-events-verbose-text` enables the export of non-scalar values for the `Test\AssertionSucceeded` and `Test\AssertionFailed` events
* [#5524](https://github.com/sebastianbergmann/phpunit/issues/5524): Do not export data passed to test for PHPUnit\Event\Code\TestMethod value object by default
* [#5526](https://github.com/sebastianbergmann/phpunit/issues/5526): Do not limit number of columns to 80 on non-interactive TTY
* Exceptions thrown by third-party event subscribers are now reported as test runner warnings
* The name of the top-level test suite that is created when a directory or file path is passed as an argument to the test runner is now `CLI Arguments`
* Simplified the failure description for `assertInstanceOf()` and `assertNotInstanceOf()`
Expand Down
8 changes: 1 addition & 7 deletions src/TextUI/Configuration/Merger.php
Original file line number Diff line number Diff line change
Expand Up @@ -211,16 +211,14 @@ public function merge(CliConfiguration $cliConfiguration, XmlConfiguration $xmlC
$outputToStandardErrorStream = $xmlConfiguration->phpunit()->stderr();
}

$maxNumberOfColumns = (new Console)->getNumberOfColumns();

if ($cliConfiguration->hasColumns()) {
$columns = $cliConfiguration->columns();
} else {
$columns = $xmlConfiguration->phpunit()->columns();
}

if ($columns === 'max') {
$columns = $maxNumberOfColumns;
$columns = (new Console)->getNumberOfColumns();
}

if ($columns < 16) {
Expand All @@ -231,10 +229,6 @@ public function merge(CliConfiguration $cliConfiguration, XmlConfiguration $xmlC
);
}

if ($columns > $maxNumberOfColumns) {
$columns = $maxNumberOfColumns;
}

assert(is_int($columns));

$noExtensions = false;
Expand Down

0 comments on commit ccb711a

Please sign in to comment.