Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don`t clear photo metadata #237

Closed
lpite opened this issue Mar 5, 2023 · 10 comments · Fixed by #625
Closed

Don`t clear photo metadata #237

lpite opened this issue Mar 5, 2023 · 10 comments · Fixed by #625
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@lpite
Copy link

lpite commented Mar 5, 2023

Is your feature request related to a problem? Please describe.

Localsend clears all metadata from photos

Describe the solution you'd like

Describe alternatives you've considered

No response

Additional context

No response

@Tienisto
Copy link
Member

Tienisto commented Mar 6, 2023

Can you tell me what platforms you use?

Does this error still exist if "Save media to gallery" is turned off?

@lpite
Copy link
Author

lpite commented Mar 8, 2023

platform ios or windows.

if "Save media to gallery" is turned off it saves metadata but if add to gallery date is not right

@wenLiangcan
Copy link

wenLiangcan commented Mar 11, 2023

Same here. The images I sent to my iPad from Windows by LocalSend had been reduced more than half the size and lost all the EXIF data. I did not notice this at the first time and deleted all the original files 😰

@Tienisto Tienisto added the bug Something isn't working label Mar 12, 2023
@Tienisto
Copy link
Member

I feel sorry for you...

I don't know a solution yet because "Save media to gallery" is handled by https://pub.dev/packages/image_gallery_saver and I don't know if there is a better library that actually respects EXIF data.

@wenLiangcan
Copy link

No problem and thanks for your work.

By having a look at the library you mentioned, may I suggest some advices? (Since I don't own a Mac, I'm afraid that I couldn't help on contributions of code)

  • There is a default value 80 of the parameter quality of the method saveImage. So, the way you calling it currently would cause compression of the images.
  • The saveImage method converts image of any format to JPEG, I think this is the reason why metadata gets lost.
  • The way to keep the original media files is using the saveFile method.

@Tienisto
Copy link
Member

@wenLiangcan
Copy link

oops, sorry, I get you wrong

@TheGB0077
Copy link
Contributor

TheGB0077 commented Mar 23, 2023

This library says that it does no modifications to the source file, so maybe it's worth a look 🤔
https://pub.dev/packages/add_to_gallery

Although it doesn't handle videos, that is not great...

@Actuallymax
Copy link

same here, switch to landrop then everything is fine

@liuguanglin
Copy link

This bug still exists on the Android client V1.14.0.
I sent photos from Android to Windows, but the GPS information on these photos was lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants