Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate image_gallery_saver to gal #625

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Migrate image_gallery_saver to gal #625

merged 2 commits into from
Aug 22, 2023

Conversation

natsuk4ze
Copy link
Contributor

@natsuk4ze natsuk4ze commented Aug 22, 2023 •
edited

⚠️ This is not tested please test by co-authoring. @Tienisto

This will

@Tienisto
Copy link
Member

One question, does it also fix #237 ? This would be great!

@natsuk4ze
Copy link
Contributor Author

natsuk4ze commented Aug 22, 2023 •
edited

One question, does it also fix #237 ? This would be great!

Maybe It should be.

@natsuk4ze
Copy link
Contributor Author

It should be noted that gal does not support the omission of file extensions.
Please see: https://github.com/natsuk4ze/gal/wiki/Formats

@Tienisto
Copy link
Member

Thank you! Saving GIFs and persisting metadata works now!

@Tienisto Tienisto marked this pull request as ready for review August 22, 2023 10:57
@Tienisto Tienisto merged commit 5997b72 into localsend:main Aug 22, 2023
2 checks passed
@natsuk4ze
Copy link
Contributor Author

np👌

@natsuk4ze natsuk4ze deleted the migrate-image_gallery_saver-to-gal branch August 22, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report - iOS devices cannot receive full GIF files Don`t clear photo metadata
2 participants
@natsuk4ze @Tienisto