Bugfix 1114 #1115
Bugfix 1114 #1115
Conversation
|
it's test pass on windows10&win11&Ubuntu 22.04.3 LTS |
| @@ -112,6 +113,10 @@ class PersistenceService { | |||
| await prefs.setInt(_version, 1); | |||
| } | |||
|
|
|||
| if (prefs.getInt(_anonymousAccess) == null) { | |||
There was a problem hiding this comment.
You don't need to initialize it here.
Initialization is only needed if you don't have a stable default value but I have seen that you have a default value (line 242)
| @@ -233,6 +238,14 @@ class PersistenceService { | |||
| await _prefs.setInt(_portKey, port); | |||
| } | |||
|
|
|||
| int getAnonymousAccess() { | |||
| return _prefs.getInt(_anonymousAccess) ?? 0; | |||
There was a problem hiding this comment.
If you intend to have 3 or more options, then an enum should be used (see getSendMode, setSendMode below).
An int is not type safe enough which could lead to bugs.
There was a problem hiding this comment.
Thinking again about this: You commented somewhere that 2 is only temporary. Then we only need to persist 2 states. In this case, a bool should be used here.
There was a problem hiding this comment.
Thinking again about this: You commented somewhere that
2is only temporary. Then we only need to persist 2 states. In this case, aboolshould be used here.
if use 2 states, only on/off can be use ;
in the share via link page, there is also a switch for temporay enablement, and it can't affect the global configuration.
so needs 3 states for this functional， globalOn/ globalOff/ onceOn
i will refactor code to enums later,
There was a problem hiding this comment.
or use 2 configuration to done this , one use to global config, one use to temporary config
but i think int is better use to, first Bit use to global config, and seceond Bit use to temporary config
There was a problem hiding this comment.
Thinking again about this: You commented somewhere that
2is only temporary. Then we only need to persist 2 states. In this case, aboolshould be used here.
i already refactor to bool
use 2 bool variable to control global setting and temporary setting respectively
|
Thank you |
|
In my opinion, this isn't the parameter that most people will use because it's quite specific. Therefore, once again, in my opinion, it would be worth moving it to the "Advanced settings". |
|
Thanks @sergd88. I moved it to advanced settings now. |
implements for #1114
add allow anonymous Access the link share file,
append global setting and onece share settting
yes, you also can be setting on share link page, if global setting is off:
global settting will be auto override to the share link page setting:
