Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not save to history option #632

Merged
merged 1 commit into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- feat: use switches instead of dropdowns for settings (@forecaster-cyber)
- feat: text message dialog is multiline only (@Tienisto)
- feat: add option to disable animations (@Tienisto)
- feat: add option to not save to history (@Tienisto)
- feat(desktop): bind "ESC" key to go to the previous page (@RiverTwilight, @Tienisto)
- feat(android, ios): open link in new browser tab (@Tienisto)
- feat(linux): enable autostart feature (@TheGB0077)
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/_missing_translations_bn.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"animations": "Animations"
},
"receive": {
"downloads": "(Downloads)"
"downloads": "(Downloads)",
"saveToHistory": "Save to history"
},
"network": {
"multicastGroup": "Multicast",
Expand Down
8 changes: 1 addition & 7 deletions assets/i18n/_missing_translations_fa.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,5 @@
"@@info": [
"Here are translations that exist in <en> but not in <fa>.",
"After editing this file, you can run 'dart run slang apply --locale=fa' to quickly apply the newly added translations."
],
"settingsTab": {
"general": {
"animations": "Animations"
},
"advancedSettings": "Advanced settings"
}
]
}
3 changes: 2 additions & 1 deletion assets/i18n/strings.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Destination",
"downloads": "(Downloads)",
"saveToGallery": "Save media to gallery"
"saveToGallery": "Save media to gallery",
"saveToHistory": "Save to history"
},
"network": {
"title": "Network",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_ar.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "حفظ في",
"downloads": "(التنزيلات)",
"saveToGallery": "حفظ الوسائط في المعرض"
"saveToGallery": "حفظ الوسائط في المعرض",
"saveToHistory": "حفظ في التاريخ"
},
"network": {
"title": "شبكة الاتصال",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_ca.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Destinació",
"downloads": "(Descàrregues)",
"saveToGallery": "Desar media a la galeria"
"saveToGallery": "Desar media a la galeria",
"saveToHistory": "Desa a l'historial"
},
"network": {
"title": "Xarxa",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_cs.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Uložit do",
"downloads": "(Downloads)",
"saveToGallery": "Uložit média do galerie"
"saveToGallery": "Uložit média do galerie",
"saveToHistory": "Uložit do historie"
},
"network": {
"title": "Síť",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_de.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Ziel-Ordner",
"downloads": "(Downloads)",
"saveToGallery": "Medien in die Gallerie speichern"
"saveToGallery": "Medien in die Gallerie speichern",
"saveToHistory": "In Verlauf speichern"
},
"network": {
"title": "Netzwerk",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_es-ES.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Destino",
"downloads": "(Descargas)",
"saveToGallery": "Guardar media en la galería"
"saveToGallery": "Guardar media en la galería",
"saveToHistory": "Guardar en el historial"
},
"network": {
"title": "Red",
Expand Down
9 changes: 6 additions & 3 deletions assets/i18n/strings_fa.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,16 @@
"saveWindowPlacement": "خروج: ذخیره قرار دادن پنجره",
"minimizeToTray": "خروج: ارسال برنامه به سیستم تری",
"launchAtStartup": "شروع خودکار پس از ورود به سیستم",
"launchMinimized": "شروع خودکار: شروع به صورت پنجره پنهان"
"launchMinimized": "شروع خودکار: شروع به صورت پنجره پنهان",
"animations": "انیمیشن‌ها"
},
"receive": {
"title": "دریافت",
"quickSave": "@:general.quickSave",
"destination": "مقصد",
"downloads": "(دانلودها)",
"saveToGallery": "ذخیره رسانه در گالری"
"saveToGallery": "ذخیره رسانه در گالری",
"saveToHistory": "ذخیره در تاریخچه"
},
"network": {
"title": "شبکه",
Expand All @@ -114,7 +116,8 @@
"encryption": "رمزنگاری",
"multicastGroup": "چندپخشی",
"multicastGroupWarning": "ممکن است به دلیل استفاده از چندپخشی سفارشی، دستگاه های دیگر شما را شناسایی نکنند (پیشفرض: {defaultMulticast})"
}
},
"advancedSettings": "تنظیمات پیشرفته"
},
"troubleshootPage": {
"title": "عیب یابی",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_fr-FR.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Destination",
"downloads": "(Téléchargements)",
"saveToGallery": "Sauvegarder les médias dans la galerie"
"saveToGallery": "Sauvegarder les médias dans la galerie",
"saveToHistory": "Enregistrer dans l'historique"
},
"network": {
"title": "Réseau",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_hu.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Mentés helye",
"downloads": "(Letöltések)",
"saveToGallery": "Média mentése a galériába"
"saveToGallery": "Média mentése a galériába",
"saveToHistory": "Mentés az előzmények közé"
},
"network": {
"title": "Hálózat",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_in.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Tujuan",
"downloads": "(Unduhan)",
"saveToGallery": "Simpan media ke galeri"
"saveToGallery": "Simpan media ke galeri",
"saveToHistory": "Simpan ke riwayat"
},
"network": {
"title": "Jaringan",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_it.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Destinazione",
"downloads": "(Download)",
"saveToGallery": "Salva i dati nella galleria"
"saveToGallery": "Salva i dati nella galleria",
"saveToHistory": "Salva nella cronologia"
},
"network": {
"title": "Rete",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_iw.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "יעד",
"downloads": "(הורדות)",
"saveToGallery": "שמור מדיה לגלריה"
"saveToGallery": "שמור מדיה לגלריה",
"saveToHistory": "שמור בהיסטוריה"
},
"network": {
"title": "רשת",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_ja.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "保存先",
"downloads": "(ダウンロード)",
"saveToGallery": "メディアをギャラリーに保存"
"saveToGallery": "メディアをギャラリーに保存",
"saveToHistory": "履歴に保存"
},
"network": {
"title": "ネットワーク",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_ko.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "저장 위치",
"downloads": "(다운로드 폴더)",
"saveToGallery": "미디어를 갤러리에 저장"
"saveToGallery": "미디어를 갤러리에 저장",
"saveToHistory": "히스토리에 저장"
},
"network": {
"title": "네트워크",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_ne.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "गन्तव्य",
"downloads": "(डाउनलोड)",
"saveToGallery": "ग्यालरीमा मिडिया सेव गर्नुहोस्"
"saveToGallery": "ग्यालरीमा मिडिया सेव गर्नुहोस्",
"saveToHistory": "इतिहासमा संचय गर्नुहोस्"
},
"network": {
"title": "नेटवर्क",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_nl.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Bestemming",
"downloads": "(Downloads)",
"saveToGallery": "Bewaar media in galerij"
"saveToGallery": "Bewaar media in galerij",
"saveToHistory": "Opslaan in geschiedenis"
},
"network": {
"title": "Netwerk",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_pl.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Miejsce docelowe",
"downloads": "(Pobrane)",
"saveToGallery": "Zapisz multimedia w galerii"
"saveToGallery": "Zapisz multimedia w galerii",
"saveToHistory": "Zapisz do historii"
},
"network": {
"title": "Sieć",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_pt-BR.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Destino",
"downloads": "(Downloads)",
"saveToGallery": "Salvar mídia na Galeria"
"saveToGallery": "Salvar mídia na Galeria",
"saveToHistory": "Salvar no histórico"
},
"network": {
"title": "Rede",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_ru.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Сохранять в",
"downloads": "(Загрузки)",
"saveToGallery": "Сохранять медиафайлы в галерею"
"saveToGallery": "Сохранять медиафайлы в галерею",
"saveToHistory": "Сохранить в историю"
},
"network": {
"title": "Сеть",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_sv.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Destination",
"downloads": "(Hämtade)",
"saveToGallery": "Spara media i galleriet"
"saveToGallery": "Spara media i galleriet",
"saveToHistory": "Spara till historik"
},
"network": {
"title": "Nätverk",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_tr.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Hedef klasör",
"downloads": "(İndirilenler)",
"saveToGallery": "Medyayı galeriye kaydet"
"saveToGallery": "Medyayı galeriye kaydet",
"saveToHistory": "Geçmişe kaydet"
},
"network": {
"title": "Ağ",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_uk.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "Зберігати в теку",
"downloads": "(Завантаження)",
"saveToGallery": "Зберігати медіафайли до галереї"
"saveToGallery": "Зберігати медіафайли до галереї",
"saveToHistory": "Зберегти в історію"
},
"network": {
"title": "Мережа",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_ur.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "منزل",
"downloads": "(ڈاؤن لوڈ)",
"saveToGallery": "میڈیا کو گیلری میں محفوظ کریں۔"
"saveToGallery": "میڈیا کو گیلری میں محفوظ کریں۔",
"saveToHistory": "تاریخچہ میں محفوظ کریں"
},
"network": {
"title": "نیٹ ورک",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_zh-CN.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "保存目录",
"downloads": "(下载)",
"saveToGallery": "保存到相册"
"saveToGallery": "保存到相册",
"saveToHistory": "保存到历史记录"
},
"network": {
"title": "网络",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_zh-HK.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "儲存位置",
"downloads": "(下載資料夾)",
"saveToGallery": "Save 落相簿"
"saveToGallery": "Save 落相簿",
"saveToHistory": "保存到歷史紀錄"
},
"network": {
"title": "網路",
Expand Down
3 changes: 2 additions & 1 deletion assets/i18n/strings_zh-TW.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
"quickSave": "@:general.quickSave",
"destination": "儲存目錄",
"downloads": "(下載)",
"saveToGallery": "儲存媒體至相簿"
"saveToGallery": "儲存媒體至相簿",
"saveToHistory": "儲存至歷史紀錄"
},
"network": {
"title": "網路",
Expand Down
1 change: 1 addition & 0 deletions lib/model/state/settings_state.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class SettingsState with _$SettingsState {
required String multicastGroup,
required String? destination, // null = default
required bool saveToGallery, // only Android, iOS
required bool saveToHistory,
required bool quickSave, // automatically accept file requests
required bool minimizeToTray, // minimize to tray instead of exiting the app
required bool launchAtStartup, // Tracks if the option is enabled on Linux
Expand Down
29 changes: 19 additions & 10 deletions lib/pages/tabs/settings_tab.dart
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,15 @@ class _SettingsTabState extends State<SettingsTab> with Riverpie {
},
),
)),
if (_advanced)
_BooleanEntry(
label: t.settingsTab.general.animations,
value: settings.enableAnimations,
onChanged: (b) async {
await ref.notifier(settingsProvider).setEnableAnimations(b);
},
),
],
if (_advanced)
_BooleanEntry(
label: t.settingsTab.general.animations,
value: settings.enableAnimations,
onChanged: (b) async {
await ref.notifier(settingsProvider).setEnableAnimations(b);
},
),
],
),
_SettingsSection(
Expand Down Expand Up @@ -259,10 +259,18 @@ class _SettingsTabState extends State<SettingsTab> with Riverpie {
await ref.notifier(settingsProvider).setSaveToGallery(b);
},
),
_BooleanEntry(
label: t.settingsTab.receive.saveToHistory,
value: settings.saveToHistory,
onChanged: (b) async {
await ref.notifier(settingsProvider).setSaveToHistory(b);
},
),
],
),
_SettingsSection(
title: t.settingsTab.network.title,
padding: const EdgeInsets.only(bottom: 0),
children: [
AnimatedCrossFade(
crossFadeState: serverState != null &&
Expand Down Expand Up @@ -467,7 +475,6 @@ class _SettingsTabState extends State<SettingsTab> with Riverpie {
icon: const Icon(Icons.info),
label: Text(t.aboutPage.title),
),
const SizedBox(height: 5),
TextButton.icon(
onPressed: () async {
await context.push(() => const ChangelogPage());
Expand Down Expand Up @@ -560,16 +567,18 @@ class _BooleanEntry extends StatelessWidget {
class _SettingsSection extends StatelessWidget {
final String title;
final List<Widget> children;
final EdgeInsets padding;

const _SettingsSection({
required this.title,
required this.children,
this.padding = const EdgeInsets.only(bottom: 15),
});

@override
Widget build(BuildContext context) {
return Padding(
padding: const EdgeInsets.only(bottom: 15),
padding: padding,
child: Card(
child: Padding(
padding: const EdgeInsets.only(left: 15, right: 15, top: 15),
Expand Down
Loading