New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: possible race condition leading to zero files #659

Merged

Tienisto merged 1 commit into main from feature/fix-possible-race-condition

Sep 4, 2023

Member

Tienisto commented Sep 4, 2023 •

edited

The progress indicator is wrong sometimes because its total size/count value is calculated once by looking for files with tokens.

The calculation happens initially assuming that no files has been sent yet (because each receive request will set the token null).

On very fast networks, the request is already received leading to an invalid amount of files with tokens.

The solution is to look for the status == skipped condition because this should never change.


          fix: possible race condition leading to zero files

cba5bf1

Tienisto merged commit 061630f into main

2 checks passed

Tienisto deleted the feature/fix-possible-race-condition branch

September 4, 2023 11:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment