Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file/image transfer by pasting files from the clipboard. #674

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Sep 8, 2023

fixes #568
fixes #210

PR Description

This PR add feature to send files that are copied to the clipboard

Demo video

https://www.loom.com/share/929b2113cc4a487e9b78781c0e30facd


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart gitstart marked this pull request as ready for review September 8, 2023 12:27
@Tienisto
Copy link
Member

Tienisto commented Sep 9, 2023

Thank you! I will test this out in a few days.

@Tienisto
Copy link
Member

Tienisto commented Sep 10, 2023

It works nice!

Do you know if this can be made more general? If I paste text, it does not work.

Thinking about this feature again, I think it would be simpler if a dialog is opened if the Flutter window gets refocused. Like "Do you want to use the clipboard contents? Cancel | Use Clipboard

This way, we don't need to add another button (that keeps the UI more clean).

Let me know if you can do that.

@gitstart
Copy link
Contributor Author

Hi @Tienisto thanks for reviewing PR.

We can try to make pasting text work but do you think popup a dialog asking if user want to use clipboard content or not is a good user experience? If so then please let us know we will make changes accordingly.

@Tienisto
Copy link
Member

You are right. I will just merge this until we have a better idea.

@Tienisto Tienisto merged commit 13f48d3 into localsend:main Sep 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants