Migrate to AWS_ENDPOINT_URL #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffyP
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Thanks for adapting the sample @joe4dev!
sorry for the late reply, totally missed the ping.
ad follow-up: yes, you are right! I think that was just automation of adapting the samples, because initially we tried to make samples work with community version as well. Which for RDS obviously wouldn't work at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt
AWS_ENDPOINT_URLas the official endpoint variable introduced by AWS.See https://docs.localstack.cloud/user-guide/tools/transparent-endpoint-injection/
/cc repo maintainer @steffyP
Suggested Follow-Up
Why do we adopt the application code for LocalStack rather than injecting the configuration through IaC like in the original AWS example?
https://github.com/aws-samples/amazon-rds-init-cdk/blob/main/demos/rds-init-fn-code/index.js#L14
IMHO, It would be better to adopt clean IaC practices and separate code from configuration. Then we don't need to rely on LocalStack-only environment variables.
Similar case for localstack-samples/sample-serverless-rds-proxy-demo#18