Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LocalStack importing issue #5

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Fix LocalStack importing issue #5

merged 6 commits into from
Oct 20, 2023

Conversation

simonrw
Copy link
Collaborator

@simonrw simonrw commented Oct 20, 2023

Motivation

There is a bug in this code: currently when imported via node, the relative package imports do not work, and so AppSync is broken. This change was unfortunately detected by LocalStack, not this project.

Changes

  • Fix the import issue by embedding all local code into the index.js file
  • Add an integration test that runs the code as the LocalStack AppSync emulator does

This is to quickly fix the pipeline. I want to split out into separate
packages in the future, but the LocalStack pipeline is failing.
This test executes the utilities like the AppSync emulation does in
LocalStack.
@simonrw simonrw self-assigned this Oct 20, 2023
This will be nicer to localise test failures
The process need not be interactive nor allocate a tty. In fact the
tests fail because they cannot allocate stdin as a tty
@simonrw simonrw marked this pull request as ready for review October 20, 2023 10:23
@simonrw simonrw merged commit 9fbeafe into main Oct 20, 2023
2 checks passed
@simonrw simonrw deleted the ls-integration-test branch October 20, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant