Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set s3ForcePathStyle for S3 client in SFn internal SDK #13

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Set s3ForcePathStyle for S3 client in SFn internal SDK #13

merged 3 commits into from
Feb 1, 2023

Conversation

whummer
Copy link
Member

@whummer whummer commented Feb 1, 2023

Set s3ForcePathStyle for S3 client in SFn internal SDK - fixes an error when running an AWS SDK call from a StepFunction execution:

  originalError: Error: getaddrinfo ENOTFOUND test-bucket-be014846.192.168.65.2
      at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:71:26) {
    errno: -3008,
    code: 'NetworkingError',

@whummer whummer mentioned this pull request Feb 1, 2023
Merged
dominikschubert
dominikschubert approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for patching this

@whummer whummer merged commit 6f56dd5 into master Feb 1, 2023
@whummer whummer deleted the sfn-s3-path branch February 1, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whummer @dominikschubert