-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor build process, build onefile, upgrade to v2.1.0, add homebrew release #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! looks like a great first iteration :-)
- runner: ubuntu-20.04 | ||
os: linux | ||
arch: amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it makes sense to add older/newer versions of linux distros to make sure we have a range of glibc versions covered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, there's no older version than Ubuntu 20.04 and MacOS 11 for GitHub-hosted runners and just ubuntu-latest for buildjet runners. All these runners currently use GCC 10. Binaries compiled with an older GCC version are compatible to newer ones (they are forward-compatible), so choosing the "oldest" available seemed to be the best approach.
Here's the support policy for GitHub Runners: https://github.com/actions/runner-images#software-and-image-support
They basically always support the last three major versions of the GCC toolchain.
This PR contains the following changes:
localstack-cli
formula inlocalstack/homebrew-tap
when a draft release is published.