Enhance implementation of is_comma_delimited_list to fix --services in pods CLI

[whummer]

Motivation

Enhance implementation of is_comma_delimited_list(..) to fix --services in pods CLI.

We are currently not accepting dashes in items of comma-separated lists, which is required, e.g., for cognito-idp in the following command:

$ localstack -d pod save --services s3,cognito-idp test-123
...
❌ Error: Input the services as a comma-delimited list

Changes

• adjust the logic in is_comma_delimited_list(..) to allow passing an item_regex
• define a default DEFAULT_REGEX_LIST_ITEM regex that allows alphanumeric characters as well as dashes
• addjust and extend the unit tests

As far as I can see, the util function is currently only used for the pods client logic, so it should not break existing logic in other places.

[coveralls]

coverage: 83.827% (+0.002%) from 83.825%
when pulling 2316c1c on comma-list
into 45d39ed on master.

[github-actions]

LocalStack Community integration with Pro

    2 files      2 suites   1h 21m 24s ⏱️
2 615 tests 2 366 ✅ 249 💤 0 ❌
2 617 runs  2 366 ✅ 251 💤 0 ❌

Results for commit 2316c1c.

[giograno]

Thanks for the quick fix @whummer. Was this related to your recent errors when saving a pod?

[whummer]

Was this related to your recent errors when saving a pod?

@giograno Partially, at least this one was reproducible. Will keep digging more and will keep you posted if I discover more issues 👍