New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SFN] Enhancements for Map State #10204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great changes and awesome test coverage!
...nctions/asl/component/state/state_execution/state_map/iteration/iterator/iterator_factory.py
Outdated
Show resolved
Hide resolved
tests/aws/services/stepfunctions/templates/scenarios/scenarios_templates.py
Show resolved
Hide resolved
|
||
job.job_program.eval(env) | ||
|
||
# TODO: verify behaviour with all of these scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would be the strategy to test this? Can this be achieved with certain state machine configuration or would we need to somehow inject errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some state machines that raise error in the MapRun would inform us about this exact behaviour, but this is very connected to the tolerance control aspects of MapRun which will need supporting from both the provider side and the MapRun backend.
Motivation
Changes