Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override of legacy resource providers over new community ones for certain resources #10249

Merged
merged 1 commit into from Feb 14, 2024

Conversation

dominikschubert
Copy link
Member

Motivation

After #10242 the -ext pipeline started failing.

I unfortunately missed an edge case where we previously had legacy providers in both community and -ext (-ext providers with additional features) but now only have a new provider in community and no new one in -ext yet.

What needs to happen is that for those 3 resource types, if PRO is enabled, the legacy model from -ext is used. With the recently introduced logic it was falling back to the community provider before considering the legacy models though.

Changes

  • Until we have corresponding resource providers for these 3 resource types in -ext, I've added a manual exemption list in community. Will refactor this soon though, so this is just a temporary inconvenience.

@dominikschubert dominikschubert self-assigned this Feb 14, 2024
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Feb 14, 2024
@coveralls
Copy link

Coverage Status

coverage: 83.864% (-0.01%) from 83.878%
when pulling 1b73439 on hotfix-cfn-legacy-fallback
into f3ddfc9 on master.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 21m 24s ⏱️ +24s
2 641 tests ±0  2 394 ✅ ±0  247 💤 ±0  0 ❌ ±0 
2 643 runs  ±0  2 394 ✅ ±0  249 💤 ±0  0 ❌ ±0 

Results for commit 1b73439. ± Comparison against base commit f3ddfc9c.

@dominikschubert
Copy link
Member Author

Manual -ext run with this branch was green, so going ahead with the merge to unblock the -ext pipeline.

@dominikschubert dominikschubert merged commit ebaf4ea into master Feb 14, 2024
29 of 30 checks passed
@dominikschubert dominikschubert deleted the hotfix-cfn-legacy-fallback branch February 14, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants