Fix architecture update for Lambda function #10263
Conversation
joe4dev
added
aws:lambda
| if len(architectures) != 1: | ||
| raise ValidationException( | ||
| f"1 validation error detected: Value '[{', '.join(architectures)}]' at 'architectures' failed to " | ||
| f"satisfy constraint: Member must have length less than or equal to 1", | ||
| ) |
There was a problem hiding this comment.
| if len(architectures) != 1: | |
| raise ValidationException( | |
| f"1 validation error detected: Value '[{', '.join(architectures)}]' at 'architectures' failed to " | |
| f"satisfy constraint: Member must have length less than or equal to 1", | |
| ) | |
| if len(architectures) > 1: | |
| raise ValidationException( | |
| f"1 validation error detected: Value '[{', '.join(architectures)}]' at 'architectures' failed to " | |
| f"satisfy constraint: Member must have length less than or equal to 1", | |
| ) |
Shouldn't be an empty architectures list be fine according to the error message? (would also affect the architectores[0] below since then it won't be safe anymore.
There was a problem hiding this comment.
If that's not the case (bc AWS treats it as null and thus returns the error msg below), please add a comment 👍
There was a problem hiding this comment.
Added a comment:
# An empty list of architectures is also forbidden. Further exceptions are tested here for create_function:
# tests.aws.services.lambda_.test_lambda_api.TestLambdaFunction.test_create_lambda_exceptions| Limitation: only works on ARM hosts that support x86 emulation. | ||
| def test_mixed_architecture(self, create_lambda_function, aws_client, snapshot): | ||
| """Test emulation of a lambda function changing architectures. | ||
| Limitation: only works on hosts that support both ARM and AMD64 architectures. |
There was a problem hiding this comment.
Interesting limitation. Think we should introduce a marker for this
There was a problem hiding this comment.
Agree that adding marker is better than the plain skip. Maybe adding an arm marker:
only_on_amd64 = pytest.mark.only_on_amd64
only_on_arm64 = pytest.mark.only_on_arm64
This special test would then have both markers.
There was a problem hiding this comment.
It's just visually a bit tricky to distinguish:
amd64
arm64
There was a problem hiding this comment.
True but fortunately markers are mostly for automation and filtering purposes, so I'd say that's ok 👍
Motivation
UpdateFunctionCode does not support updating the Architectures (e.g., x64 => ARM).
This issue has been reported and reproduced by @cabeaulac based on customer input.
Changes
test_mixed_architectureto useUpdateFunctionCodeUpdateFunctionCodeTesting
Our CI pipeline currently does not support cross-architecture emulation. Therefore, this change can only be tested locally on a machine with cross-architecture support (e.g., ARM MacBook):
tests.aws.services.lambda_.test_lambda.TestLambdaBehavior.test_mixed_architecturetests.aws.services.lambda_.test_lambda.TestLambdaBehavior.test_mixed_architecture