Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for SQS FIFO dedup behaviour in high throughput mode #10274

Merged
merged 2 commits into from Feb 19, 2024

Conversation

baermat
Copy link
Member

@baermat baermat commented Feb 19, 2024

Motivation

While investigating a support case, I stumbled upon this behaviour which is not yet implemented. If a message uses the same message deduplication ID while the fifo queue is set to "high throughput mode", the deduplication id seems to be evaluated at a group level and not at the queue level. The effects on ordering still need to be investigated once we implement this feature (it is unclear to me why I would use this high throughput fifo queue over a regular queue).

Changes

  • adds 1 test each for:
    • Same deduplication id with different message groups, normal mode
    • Same deduplication id with different message groups, high throughput mode

@baermat baermat added the semver: patch Non-breaking changes which can be included in patch releases label Feb 19, 2024
@baermat baermat marked this pull request as ready for review February 19, 2024 13:22
@baermat baermat requested a review from thrau as a code owner February 19, 2024 13:22
@coveralls
Copy link

Coverage Status

coverage: 83.872% (+0.007%) from 83.865%
when pulling 50241ee on sqs-fifo-same-dedup-different-grps
into b558f3a on master.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 20m 57s ⏱️ -37s
2 646 tests +4  2 397 ✅ +2  249 💤 +2  0 ❌ ±0 
2 648 runs  +4  2 397 ✅ +2  251 💤 +2  0 ❌ ±0 

Results for commit 50241ee. ± Comparison against base commit b558f3a.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is excellent, really nice find @baermat! thanks for adding the test, always great to have keep an xfailed test around for a TODO 💯

@thrau thrau merged commit ae31f63 into master Feb 19, 2024
29 of 30 checks passed
@thrau thrau deleted the sqs-fifo-same-dedup-different-grps branch February 19, 2024 20:17
@thrau thrau changed the title Sqs fifo same dedup different message groups add test for SQS FIFO dedup behaviour in high throughput mode Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants