fix S3 copy-source format validation #10338

bentsku · 2024-02-27T11:15:09Z

Motivation

As reported in #10328, we would not properly validate the CopySource parameter before parsing it.

Added a check for the presence of / before splitting, and a test for the case.

fixes #10328

github-actions · 2024-02-27T11:56:53Z

2 files 2 suites 3m 16s ⏱️
390 tests 339 ✅ 51 💤 0 ❌
780 runs 678 ✅ 102 💤 0 ❌

Results for commit 3b51208.

coveralls · 2024-02-27T12:37:17Z

coverage: 83.823% (+0.02%) from 83.803%
when pulling 3b51208 on fix-s3-copy-source-validation
into 4743245 on master.

github-actions · 2024-02-27T12:48:19Z

2 files ±0 2 suites ±0 1h 27m 48s ⏱️ - 2m 3s
2 662 tests +1 2 411 ✅ +1 251 💤 ±0 0 ❌ ±0
2 664 runs +1 2 411 ✅ +1 253 💤 ±0 0 ❌ ±0

Results for commit 3b51208. ± Comparison against base commit 4743245.

macnev2013

Thanks for fixing this. LGTM 🚀

fix copy-source format validation

2953fb0

bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases labels Feb 27, 2024

bentsku added this to the 3.2 milestone Feb 27, 2024

bentsku self-assigned this Feb 27, 2024

bentsku requested a review from macnev2013 as a code owner February 27, 2024 11:15

bentsku force-pushed the fix-s3-copy-source-validation branch from 29f9c57 to 8565452 Compare February 27, 2024 11:34

fix order for check to be in parsed copy source

3b51208

bentsku force-pushed the fix-s3-copy-source-validation branch from 8565452 to 3b51208 Compare February 27, 2024 11:51

macnev2013 approved these changes Feb 29, 2024

View reviewed changes

bentsku merged commit 307cbe9 into master Feb 29, 2024
38 checks passed

bentsku deleted the fix-s3-copy-source-validation branch February 29, 2024 11:54