Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CFn Resource Provider for AWS::SNS::Subscription and AWS::SNS::TopicPolicy #10359

Merged
merged 4 commits into from Mar 1, 2024
Merged

Added CFn Resource Provider for AWS::SNS::Subscription and AWS::SNS::TopicPolicy #10359

merged 4 commits into from Mar 1, 2024

Conversation

Morijarti
Copy link
Contributor

Changes

Migrating following resources from LegacyModel to new Resource Providers

  • AWS::SNS::Subscription
  • AWS::SNS::TopicPolicy

@Morijarti Morijarti self-assigned this Feb 29, 2024
@Morijarti Morijarti marked this pull request as draft February 29, 2024 18:23
@Morijarti Morijarti added the semver: patch Non-breaking changes which can be included in patch releases label Feb 29, 2024
@Morijarti Morijarti added this to the Playground milestone Feb 29, 2024
@Morijarti Morijarti mentioned this pull request Feb 29, 2024
Merged
dominikschubert
dominikschubert approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, linting needs to be addressed though!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 27m 14s ⏱️ + 1m 56s
2 667 tests ±0  2 418 ✅ ±0  249 💤 ±0  0 ❌ ±0 
2 669 runs  ±0  2 418 ✅ ±0  251 💤 ±0  0 ❌ ±0 

Results for commit 0d515be. ± Comparison against base commit 4754a2d.

♻️ This comment has been updated with latest results.

@Morijarti @dominikschubert
Update localstack/services/sns/resource_providers/aws_sns_topicpolicy.py
0d515be 
Co-authored-by: Dominik Schubert <dominik.schubert91@gmail.com>
@coveralls
Copy link

Coverage Status

coverage: 83.737% (-0.09%) from 83.825%
when pulling 0d515be on feat/cfn_ses_adding_update_to_providers
into 4754a2d on master.

@Morijarti Morijarti marked this pull request as ready for review March 1, 2024 11:53
@Morijarti Morijarti merged commit c041ef3 into master Mar 1, 2024
29 checks passed
@Morijarti Morijarti deleted the feat/cfn_ses_adding_update_to_providers branch March 1, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@simonrw simonrw Awaiting requested review from simonrw

@pinzon pinzon Awaiting requested review from pinzon

@bentsku bentsku Awaiting requested review from bentsku bentsku is a code owner

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@Morijarti Morijarti

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Morijarti @coveralls @dominikschubert