Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix S3 GLACIER_IR not being an archive type #10395

Merged
merged 3 commits into from Mar 8, 2024
Merged

fix S3 GLACIER_IR not being an archive type #10395

merged 3 commits into from Mar 8, 2024

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Mar 5, 2024

Motivation

As reported in #10393, the GLACIER_IR is not an archive type and can be retrieved instantly.

Changes

  • update an existing test to validate the instant retrieval of storage classes or not
  • remove GLACIER_IR from the archive types

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases labels Mar 5, 2024
@bentsku bentsku self-assigned this Mar 5, 2024
@bentsku bentsku requested a review from macnev2013 as a code owner March 5, 2024 17:24
@bentsku bentsku linked an issue Mar 5, 2024 that may be closed by this pull request
bug: Unable to get-object from S3 Glacier Instant Retrieval #10393
Closed
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   3m 12s ⏱️ -7s
392 tests +2  341 ✅ +2   51 💤 ±0  0 ❌ ±0 
784 runs  +4  682 ✅ +4  102 💤 ±0  0 ❌ ±0 

Results for commit f0ea0b0. ± Comparison against base commit 13fe1ed.

This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both. 
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[DEEP_ARCHIVE]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[GLACIER]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[GLACIER_IR]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[INTELLIGENT_TIERING]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[ONEZONE_IA]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[REDUCED_REDUNDANCY]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[STANDARD]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[STANDARD_IA]

tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[DEEP_ARCHIVE-False]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[GLACIER-False]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[GLACIER_IR-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[INTELLIGENT_TIERING-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[ONEZONE_IA-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[REDUCED_REDUNDANCY-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[STANDARD-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[STANDARD_IA-True]
tests.aws.services.s3.test_s3_concurrency.TestParallelBucketCreation ‑ test_parallel_object_creation_and_read
tests.aws.services.s3.test_s3_concurrency.TestParallelBucketCreation ‑ test_parallel_object_read_range

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 31m 10s ⏱️ + 3m 49s
2 691 tests +3  2 435 ✅ +2  256 💤 +1  0 ❌ ±0 
2 693 runs  +3  2 435 ✅ +2  258 💤 +1  0 ❌ ±0 

Results for commit f0ea0b0. ± Comparison against base commit 13fe1ed.

This pull request removes 8 and adds 11 tests. Note that renamed tests count towards both. 
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[DEEP_ARCHIVE]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[GLACIER]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[GLACIER_IR]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[INTELLIGENT_TIERING]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[ONEZONE_IA]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[REDUCED_REDUNDANCY]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[STANDARD]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[STANDARD_IA]

tests.aws.services.apigateway.test_apigateway_common.TestStages ‑ test_update_stage_remove_wildcard
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[DEEP_ARCHIVE-False]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[GLACIER-False]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[GLACIER_IR-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[INTELLIGENT_TIERING-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[ONEZONE_IA-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[REDUCED_REDUNDANCY-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[STANDARD-True]
tests.aws.services.s3.test_s3.TestS3 ‑ test_put_object_storage_class[STANDARD_IA-True]
tests.aws.services.s3.test_s3_concurrency.TestParallelBucketCreation ‑ test_parallel_object_creation_and_read
…
This pull request skips 1 test. 
tests.aws.services.stepfunctions.v2.timeouts.test_timeouts.TestTimeouts ‑ test_fixed_timeout_service_lambda_with_path

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Coverage Status

coverage: 83.397% (+0.001%) from 83.396%
when pulling f0ea0b0 on fix-s3-storage-class
into 13fe1ed on master.

macnev2013
macnev2013 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@macnev2013 macnev2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bentsku bentsku merged commit 61c2408 into master Mar 8, 2024
36 checks passed
@bentsku bentsku deleted the fix-s3-storage-class branch March 8, 2024 18:23
@thrau thrau added aws:glacier Amazon S3 Glacier and removed aws:glacier Amazon S3 Glacier labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macnev2013 macnev2013 macnev2013 approved these changes

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Unable to get-object from S3 Glacier Instant Retrieval
4 participants
@bentsku @coveralls @macnev2013 @thrau