Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused CFN_RESOURCE_PROVIDER_OVERRIDES option #10402

Merged
merged 1 commit into from Mar 6, 2024

Conversation

dominikschubert
Copy link
Member

Motivation

While this technically removes an option, it was one that has not been communicated and was only used internally for configuring generated tests. Even that hasn't been relevant since we've switched to prioritizing newer resource providers over the legacy ones by default.

Changes

  • Remove config CFN_RESOURCE_PROVIDER_OVERRIDES and all usage

@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Mar 6, 2024
@dominikschubert dominikschubert self-assigned this Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 28s ⏱️
392 tests 341 ✅  51 💤 0 ❌
784 runs  682 ✅ 102 💤 0 ❌

Results for commit 60cfab5.

@coveralls
Copy link

Coverage Status

coverage: 85.889% (+0.004%) from 85.885%
when pulling 60cfab5 on cfn-cleanup
into cc55cb4 on master.

@dominikschubert dominikschubert marked this pull request as ready for review March 6, 2024 11:00
Copy link

github-actions bot commented Mar 6, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 28m 44s ⏱️
2 691 tests 2 435 ✅ 256 💤 0 ❌
2 693 runs  2 435 ✅ 258 💤 0 ❌

Results for commit 60cfab5.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! if it wasn't documented as part of the public config API, no need to really treat it as a major change 👍

@dominikschubert dominikschubert merged commit f3c2b4b into master Mar 6, 2024
39 checks passed
@dominikschubert dominikschubert deleted the cfn-cleanup branch March 6, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants