New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fix for cfn-response code for nodejs custome resource #10408
Conversation
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 28m 35s ⏱️ + 1m 11s Results for commit a33b3a6. ± Comparison against base commit 87f747f. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
localstack/services/lambda_/resource_providers/aws_lambda_function.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, in terms of testing this is actually covered in -ext. I think currently we only cover the python one, but we should extend this to have both a python-based as well as a NodeJS based custom resource test 👍
@@ -189,7 +189,7 @@ def send(event, context, responseStatus, responseData, physicalResourceId=None, | |||
var parsedUrl = url.parse(event.ResponseURL); | |||
var options = { | |||
hostname: parsedUrl.hostname, | |||
port: 443, | |||
port: parsedUrl.port, // Modified line: LS uses port 4566 for https; hard coded 443 causes error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default localstack/localstack-pro will actually use 443 but that should be fine as it extracts it from the url anyway now 👍
Motivation
Custom resource models backed by nodejs lambda are experiencing deployment issues as a result of the nodejs cfn-response file containing an additional line ending character within the container, and the request is directing traffic to port 443.
Changes
Testing
The custom resource are not able to be deployed on this project so there is no need for a test