update s3 lambdas to node20 #10417
Merged
update s3 lambdas to node20 #10417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:s3
bentsku
requested review from
macnev2013,
joe4dev,
dominikschubert and
dfangl
as code owners
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 30s ⏱️ Results for commit 216752d. ♻️ This comment has been updated with latest results. |
bentsku
changed the title
dfangl
approved these changes
Mar 8, 2024
tests/aws/services/s3/test_s3.py
Outdated
| ) | ||
| temp_folder = create_tmp_folder_lambda( | ||
| handler_file, | ||
| run_command="npm i @aws-sdk/util-endpoints @aws-sdk/client-s3 @aws-sdk/s3-request-presigner @aws-sdk/middleware-endpoint", | ||
| run_command="npm i @aws-sdk/util-endpoints @aws-sdk/client-s3 @aws-sdk/s3-request-presigner @aws-sdk/middleware-endpoint fast-xml-parser", |
There was a problem hiding this comment.
Should we merge this change if they correct it upstream anyway?
There was a problem hiding this comment.
oops I forgot to do it, it was a bit late 😓 will push the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It seems the pipeline just failed with some missing dependency for some lambdas used in S3:fast-xml-parser. Not sure what produced this, maybe it's not a default dependency anymore.Edit: ah, well, they updated it. aws/aws-sdk-js-v3#5869
It seems they released a version with an issue, so this is not blocking anymore. I'll remove the added dependency but updating the lambda can't be bad.
Changes
Added the dependency to the list of install.I've also spotted that Node14 is not supported anymore in lambda, so I've updated the lambda used to Node 20 + to use ES6.