New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use rolo twisted gateway integration #10428
Conversation
the test run with twisted was successful, community against pro tests were failing due to #10444 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I can see the line regarding the removal of localstack.http.asgi.ASGIWebSocket
has been done in #10435 instead.
Nice cleanup 🧹 awesome to see things evolving!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup 👍
Motivation
The coded added for twisted integration in #9834 moved to rolo in localstack/rolo#8, which also includes websocket support. This PR refactors our existing code to use the new rolo version.
Changes
localstack.http.asgi.ASGIWebSocket
is removed from the APITODO
What's left to do: