Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SNS Publish exception when using empty topic #10430

Merged
merged 1 commit into from Mar 11, 2024
Merged

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Mar 11, 2024

Motivation

Found out this small issue when launching a benchmark without the initial setup. When calling SNS.Publish(Message="test", TopicArn=""), boto accepts it but it fails on LocalStack side.

Changes

  • add a test for the issue
  • add a small check to use an empty string if the value is falsy

@bentsku bentsku added aws:sns Amazon Simple Notification Service semver: patch Non-breaking changes which can be included in patch releases labels Mar 11, 2024
@bentsku bentsku requested a review from baermat March 11, 2024 10:45
@bentsku bentsku self-assigned this Mar 11, 2024
@bentsku bentsku requested a review from thrau as a code owner March 11, 2024 10:45
@coveralls
Copy link

Coverage Status

coverage: 85.675% (-0.008%) from 85.683%
when pulling fa02bfc on fix-sns-no-topic
into 0b9c6b1 on master.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 29m 49s ⏱️ - 1m 1s
2 694 tests ±0  2 438 ✅ ±0  256 💤 ±0  0 ❌ ±0 
2 696 runs  ±0  2 438 ✅ ±0  258 💤 ±0  0 ❌ ±0 

Results for commit fa02bfc. ± Comparison against base commit 0b9c6b1.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thrau thrau merged commit 55eff22 into master Mar 11, 2024
34 checks passed
@thrau thrau deleted the fix-sns-no-topic branch March 11, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:sns Amazon Simple Notification Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants