Fixed issue where TEST_DISABLE_RETRIES_AND_TIMEOUTS would get always evaluated to True #10480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to true regardless of its value
Morijarti
added
the
semver: patch
alexrashed
approved these changes
Mar 18, 2024
LocalStack Community integration with Pro 2 files 2 suites 1h 29m 47s ⏱️ Results for commit 43d215f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In current implementation
TEST_DISABLE_RETRIES_AND_TIMEOUTSwould get evaluated to True regardless if it was set to 0 or 1. Only way to get it to be false is to remove it from env variablesChanges
Replaced
os.environ.getwithis_env_true