Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: aws validated test cases in the rgsa #10496

Merged
merged 2 commits into from Mar 20, 2024
Merged

test: aws validated test cases in the rgsa #10496

merged 2 commits into from Mar 20, 2024

Conversation

macnev2013
Copy link
Contributor

Motivation

Updated test in ResourceGroupTaggingApi and made it snapshot validated.

Changes

  • Changed test cases to be snapshot validated
  • Used cleanups to delete resources instead of try catch

@macnev2013 macnev2013 added the semver: patch Non-breaking changes which can be included in patch releases label Mar 20, 2024
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 30m 2s ⏱️ - 1m 53s
2 727 tests ±0  2 472 ✅ ±0  255 💤 ±0  0 ❌ ±0 
2 729 runs  ±0  2 472 ✅ ±0  257 💤 ±0  0 ❌ ±0 

Results for commit 04f4dca. ± Comparison against base commit d95aecc.

@macnev2013 macnev2013 requested review from alexrashed and removed request for alexrashed March 20, 2024 10:06
@alexrashed alexrashed self-requested a review March 20, 2024 10:51
alexrashed
alexrashed approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Another test transformed to be AWS- and snapshot-validated! 🧹 💯

@macnev2013 macnev2013 merged commit 0c2d8a1 into master Mar 20, 2024
31 of 32 checks passed
@macnev2013 macnev2013 deleted the test/rgsa-validated branch March 20, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macnev2013 @alexrashed