Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix payload and logging for CI analytics data #10503

Merged
merged 5 commits into from Mar 21, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Mar 20, 2024

Motivation

This PR addresses two issues in sending the Tinybird analytics data introduced in #10492:

  • There is an issue with the log output, f.e. in the output of this run:
    cat: stats/stats.json: No such file or directory
    
    However, this really only impacts the debug info on what data will be sent in the step right below.
    Sending the data is not affected at all.
  • There is no workflow name being set in the payload (because the variable is not properly set).

Changes

  • Fix a small reporting issue in the Tinybird CI analytics sending.
  • Fix the workflow name in the payload.

Testing

TODO

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Mar 20, 2024
@alexrashed alexrashed added this to the 3.3 milestone Mar 20, 2024
@alexrashed alexrashed requested a review from silv-io March 20, 2024 17:40
@alexrashed alexrashed self-assigned this Mar 20, 2024
@alexrashed alexrashed changed the title fix debug output for tinybird fix debug output for CI analytics data Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 29m 51s ⏱️ + 1m 31s
2 707 tests ±0  2 452 ✅ ±0  255 💤 ±0  0 ❌ ±0 
2 709 runs  ±0  2 452 ✅ ±0  257 💤 ±0  0 ❌ ±0 

Results for commit 82197b3. ± Comparison against base commit 5068678.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed changed the title fix debug output for CI analytics data fix payload and logging for CI analytics data Mar 21, 2024
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some small suggestions/nits

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@alexrashed alexrashed force-pushed the fix-tinybird-workflow-report-debug branch from ee5c18b to db3125c Compare March 21, 2024 09:53
@alexrashed alexrashed force-pushed the fix-tinybird-workflow-report-debug branch from 57f8612 to 3f6d546 Compare March 21, 2024 10:11
@alexrashed alexrashed merged commit 748fd53 into master Mar 21, 2024
33 checks passed
@alexrashed alexrashed deleted the fix-tinybird-workflow-report-debug branch March 21, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants