Fix Lambda common build caching #10510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
added
the
semver: patch
joe4dev
requested review from
alexrashed,
dfangl and
dominikschubert
as code owners
dfangl
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The adjustments for the Lambda common ARM build introduced a path error here:
https://github.com/localstack/localstack/pull/10441/files#diff-2c0422c107fb6b5e37ccf7ed62bba7d66f32a1c7f49f627f9e444f064db255a5L251
This resulted in cache keys like
community-it-Linux-X64-lambda-common-because not matching any files results in an empty string, according to the GH Actions Docs https://docs.github.com/en/actions/learn-github-actions/expressions#hashfiles.It originated from copy/pasting the hash key from localstack-ext appearing in multiple places.
Testing
The cache key should contain a hash suffix: https://github.com/localstack/localstack/actions/caches
##[debug]["community-it-Linux-X64-lambda-common-13a67dce5356f334abe6171a9f00818db0139ba21396ad365a017d625df7394c"]Changes
localstackdirectory