Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFN] Fix SecondsPath Retrieval and Raise Runtime Errors on Invalid Inputs #10521

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Mar 22, 2024

Motivation

This pull request resolves an issue within the StepFunctions v2 interpreter, where the extraction of SecondsPath values from memory was inaccurate. The update included in this PR aligns the JsonPath extraction logic with the extraction logic strategy used in other sections of the interpreter, ensuring proper unpacking of JsonPath values.
Closes: #10505

Changes

  • Updates SecondsPath extract logic to using SFN's JSONPathUtils
  • Added related snapshot test

@MEPalma MEPalma added the semver: patch Non-breaking changes which can be included in patch releases label Mar 22, 2024
@MEPalma MEPalma added this to the 3.3 milestone Mar 22, 2024
@MEPalma MEPalma requested review from thrau and joe4dev March 22, 2024 17:45
@MEPalma MEPalma self-assigned this Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

LocalStack Community integration with Pro

    2 files  ± 0      2 suites  ±0   1h 29m 53s ⏱️ -20s
2 721 tests +11  2 466 ✅ +11  255 💤 ±0  0 ❌ ±0 
2 723 runs  +11  2 466 ✅ +11  257 💤 ±0  0 ❌ ±0 

Results for commit 22eb1dd. ± Comparison against base commit 15439a0.

♻️ This comment has been updated with latest results.

Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for the quick fix @MEPalma 👏

@MEPalma MEPalma changed the title [SFN] Fix SecondsPath Retrieval [SFN] Fix SecondsPath Retrieval and Runtime Errors on Invalid Inputs Mar 22, 2024
@MEPalma MEPalma changed the title [SFN] Fix SecondsPath Retrieval and Runtime Errors on Invalid Inputs [SFN] Fix SecondsPath Retrieval and Raise Runtime Errors on Invalid Inputs Mar 22, 2024
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MEPalma MEPalma merged commit 0a59f07 into master Mar 23, 2024
33 checks passed
@MEPalma MEPalma deleted the MEP-sfn-secondspath_fix branch March 23, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: StepFunctions: SecondsPath in Wait state throws error
2 participants