fix ASF update action to fix unused imports #10527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The latest
ruff
upgrade switched some defaults avoiding unsafe fixes to remove unused imports in init dunder files (since they would change the API interface of the module): astral-sh/ruff#10365 contained in 0.3.3.This causes our ASF update action to fail because of unfixed linting errors: https://github.com/localstack/localstack/actions/runs/8415318713
The changes in the defaults are safe, but we want to explicitly fix this for the generated APIs (which is all in the init dunder) explicitly directly when generating them.
Changes
This PR explicitly executes an unsafe lint fix with a changed config on the generated APIs in the ASF update action.
Testing
Tested locally: