New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resource providers for vpc endpoint and prefix list #10735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provider looks good for now. I mentioned we should probably use the async form of the provider methods always since it upholds the CFn resource provider contract of atomicity. Not a blocker, we might want to do a pass over "non-conforming" providers in the future once we have more accurate deployment order
tests/aws/services/cloudformation/resource_providers/ec2/test_ec2.snapshot.json
Outdated
Show resolved
Hide resolved
localstack/services/ec2/resource_providers/aws_ec2_vpcendpoint.py
Outdated
Show resolved
Hide resolved
localstack/services/ec2/resource_providers/aws_ec2_prefixlist.py
Outdated
Show resolved
Hide resolved
localstack/services/ec2/resource_providers/aws_ec2_prefixlist.py
Outdated
Show resolved
Hide resolved
localstack/services/ec2/resource_providers/aws_ec2_prefixlist.py
Outdated
Show resolved
Hide resolved
@simonrw thank you for the comments. I addressed them all and made the improvements to the resource providers. I'll merge once the checks are green again. |
Motivation
Addresses #10606. This PR adds new resource providers for the EC2 service
Changes
Testing