Opt in services to the test selection #10867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silv-io
added
the
semver: patch
silv-io
changed the title
silv-io
force-pushed
the
test-selection-opt-in
branch
from
6dfb0b5
to
858f0f4
Compare
silv-io
force-pushed
the
test-selection-opt-in
branch
from
858f0f4
to
b9e6a70
Compare
alexrashed
approved these changes
May 28, 2024
There was a problem hiding this comment.
Awesome! So many new services opting into the test selection! The amount of API dependencies seems to be a bit low to be honest, but we can grow this over time :)
And thanks for adjusting the paths after #10800. 🦸🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The test selection allows future PRs containing strictly service changes to only execute tests corresponding to those services and services that depend on them. However, to enable this, services need to opt in.
Changes
This PR offers the opportunity to opt in services to the test selection. These services are opting in with this PR:
Furthermore, paths are adjusted to the new structure, prefixed with
localstack-core/