Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev script to mount community code correctly #10983

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Jun 7, 2024

Motivation

When running the localstack.dev.run script, the LocalStack community source code is not mounted. This is due to #10800 as it moved the source code locations around. Looks like this particular instance was missed.

Changes

  • Mount the community code from localstack/localstack-core/localstack rather than localstack/localstack.

@simonrw simonrw added the area: packages Packages and installers label Jun 7, 2024
@simonrw simonrw self-assigned this Jun 7, 2024
@simonrw simonrw requested a review from thrau June 7, 2024 18:04
@simonrw simonrw added semver: patch Non-breaking changes which can be included in patch releases and removed area: packages Packages and installers labels Jun 7, 2024
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon! Seems this one slipped

Copy link

github-actions bot commented Jun 7, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 37m 25s ⏱️ +20s
3 028 tests ±0  2 693 ✅ ±0  335 💤 ±0  0 ❌ ±0 
3 030 runs  ±0  2 693 ✅ ±0  337 💤 ±0  0 ❌ ±0 

Results for commit 2cfa8ca. ± Comparison against base commit 803cbbe.

@simonrw simonrw merged commit 2f05d65 into master Jun 7, 2024
35 of 37 checks passed
@simonrw simonrw deleted the fix/dev-mount-community branch June 7, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants