Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the upload of empty S3 objects with chunk encoding #1140

Merged
merged 1 commit into from Feb 22, 2019
Merged

Fix the upload of empty S3 objects with chunk encoding #1140

merged 1 commit into from Feb 22, 2019

Conversation

Pedrock
Copy link
Contributor

@Pedrock Pedrock commented Feb 22, 2019

This commit fixes issues #869 and #538.
It should also make the test from PR #1120 pass.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 71.542% when pulling a786d68 on Pedrock:fix/upload-empty-s3-objects into 3684fcf on localstack:master.

@whummer
Copy link
Member

whummer commented Feb 22, 2019

Awesome - thanks for this fix @Pedrock !!

@whummer whummer merged commit afb58d3 into localstack:master Feb 22, 2019
@whummer whummer mentioned this pull request Feb 22, 2019
Merged
@Pedrock Pedrock deleted the fix/upload-empty-s3-objects branch February 27, 2019 10:56
@mvpc mvpc mentioned this pull request Feb 27, 2019
Closed
Stovoy pushed a commit to Nextdoor/localstack that referenced this pull request Feb 27, 2019
@Pedrock @whummer
Fix the upload of empty S3 objects with chunk encoding (localstack#1140)
8a87c4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pedrock @coveralls @whummer