Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some methods to build client async in TestUtils #1188

Closed
wants to merge 2 commits into from
Closed

Add some methods to build client async in TestUtils #1188

wants to merge 2 commits into from

Conversation

netstart
Copy link

methods to build client async in TestUtils
Some async tests

@whummer
Copy link
Member

whummer commented Mar 13, 2019

Thanks for this PR @netstart ! Can we first merge PR #839 , and then rebase this branch onto the changes made in #839 ? Would be great to merge in the entire set of changes, without running into conflicts. Thanks

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 69.363% when pulling 603ae2d on netstart:master into 56b1cfe on localstack:master.

@netstart
Copy link
Author

It's OK to me. I thought that 839 PR was forgotten,

@netstart netstart closed this Mar 13, 2019
@whummer
Copy link
Member

whummer commented Mar 13, 2019

@netstart Sorry, maybe my last message was not clear. Wasn't your PR adding some additional capabilities, in addition to #839 ? Should we re-open this PR, resolve the conflicts, and get it merged? Thanks

@netstart
Copy link
Author

I Understood, thank you for your atemption!
Don't worry, I will send other PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants