-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable handler_name to be a relative path #1775
Enable handler_name to be a relative path #1775
Conversation
Thanks for tackling this @JakeChampion . Do you think we could add a small unit test here: https://github.com/localstack/localstack/blob/master/tests/unit/test_lambda.py ? That would be great - thanks! |
… path handlers work
Any updates on this PR @JakeChampion ? Looks like the tests in CI are currently failing. Would be great if we could fix them to get this merged. Thanks! |
@whummer tests passing now |
Thanks for updating the PR @JakeChampion . I'd still feel a bit more comfortable if we could add a few unit tests, as this could have impact for a lot of people and could potentially break existing tests out there. For example, what is the expected behavior if the handler name is Another example is the handler name I'm wondering if we should simply do this instead:
Thoughts? |
@JakeChampion Any updates on this PR - do you think we could add a few unit tests to ensure the new logic covers any corner cases, and to avoid any regressions? Thanks |
@whummer I don't think I can do that, I don't know Python nor how this code-base and it's tests work. I'm happy to leave the rest of the pull-request for someone from the core-team and/or community to take over. |
Attempt to fix #1774
I agree to the contributor license agreement