Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fix for #1160 when running Java lambdas locally #2378

Merged
merged 1 commit into from May 2, 2020

Conversation

krrg
Copy link
Contributor

@krrg krrg commented May 2, 2020

#1160 describes problems caused by AWS SDK classes from the localstack-utils-fat.jar overriding classes defined in the actual Lambda jar/zip itself. This causes numerous incompatibility problems.

I was able to isolate and repro this problem with a minimal example ( https://github.com/krrg/localstack-java-classpath-debug )

@whummer implemented a partial fix for this that moved the localstack-utils-fat.jar later on the classpath, but this fix only applied to lambdas being run using the docker executor.

This PR takes a similar approach, but this time for lambdas being executed locally. Using the minimal example above, I verified that the classpath is now correctly ordered for local lambdas and that my example is able to be invoked without error.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 72.91% when pulling 8ce6923 on krrg:master into a0fadac on localstack:master.

@whummer
Copy link
Member

whummer commented May 2, 2020

Good catch - thanks for providing this fix @krrg ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants