Fix docker detection on hosts with cgroup v2 (unified hierachy) #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fantastic catch @dfangl @dominikschubert ! 👏 pretty sure this would have caused a lot of headaches in the next few weeks if you hadn't spent the time with debugging. 💯 |
thrau
approved these changes
Jul 23, 2021
whummer
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the docker detection on hosts with only cgroup unified hierachy enabled.
Thanks @dominikschubert and @thrau for helping to fix this.
Similar issue and solution as here: GoogleContainerTools/kaniko#1592
Systemd also uses this mechanism: https://github.com/systemd/systemd/blob/6604fb0207ee10e8dc05d67f6fe45de0b193b5c4/src/basic/virt.c#L523-L548
Option for overriding the check with a true value, to be able to handle the case all the detection mechanisms fail.