New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
queryStringParameters set to None when there are no GET parameters #5893
queryStringParameters set to None when there are no GET parameters #5893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this PR @jops-wtakase ! 👍 Also requesting a review from @calvernaz
Looks like the CI builds were not triggered, which can sometimes happen if the CircleCI<>Github connection is broken for your user account. Can you please try this:
- go to https://circleci.com,
- sign in with your Github credentials (Single-Sign On)
- come back here, push an empty commit onto the branch (should hopefully trigger the CI builds..)
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jops-wtakase thanks for pushing for this change. I agree None
would be a better representation of there are no query parameters, however I think we need to change this change to this code path:
event = construct_invocation_event( |
query_string_params = query_string_params or parse_request_data(method, path, "") |
parse_qs
returns an empty dict if there are no string parameters and that is passed into the Lambda event payload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
On Lambda proxy integration enabled environment, if there are no GET parameters in a request path,
queryStringParameters
should beNone
instead of{}
.