add headers to dummy WSGI environment #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
approved these changes
Apr 21, 2022
| @@ -878,9 +878,10 @@ def test_restxml_headers_parsing(): | |||
| _botocore_parser_integration_test( | |||
| service="s3", | |||
| action="PutObject", | |||
| ContentLength=0, | |||
There was a problem hiding this comment.
q / nit: Are the changes in this test on purpose or more of a left-over from your testing when implementing the changes? I don't see a problem in leaving this here, just asking. :)
There was a problem hiding this comment.
this addition is actually necessary, since now we set the content-length header correctly in our Request class, and the content-length header is translated into a member field ContentLength by the parser: https://github.com/boto/botocore/blob/b7a6f50cca3dcfdab7022a8e1ebe9e31edf57581/botocore/data/s3/2006-03-01/service-2.json#L8641-L8645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the commits that sprung from the reviews of #5876 that didn't make it into the PR because I force pushed from my old history on my laptop 🤡