Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure test fixtures/utilities #6050

Merged
merged 11 commits into from May 13, 2022
Merged

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented May 12, 2022

Some cleanup, restructuring of our pytest setup.

Mostly extracting/moving things around.

This PR intentionally tries to avoid touching any logic and doesn't move actual test files. (some tests had to be fixed/removed/skipped though)

@dominikschubert dominikschubert self-assigned this May 12, 2022
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 12, 2022 09:53 Inactive
@github-actions
Copy link

github-actions bot commented May 12, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   59m 33s ⏱️ - 2m 45s
1 008 tests  - 4     965 ✔️  - 6  43 💤 +2  0 ±0 
1 304 runs   - 4  1 234 ✔️  - 6  70 💤 +2  0 ±0 

Results for commit 56d189a. ± Comparison against base commit c31d245.

♻️ This comment has been updated with latest results.

@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 12, 2022 12:54 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 13, 2022 07:10 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 13, 2022 09:12 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 13, 2022 11:15 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 13, 2022 12:57 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 13, 2022 13:43 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 13, 2022 13:47 Inactive
@dominikschubert dominikschubert marked this pull request as ready for review May 13, 2022 15:57
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great overall, thanks for cleaning up 💯 just a couple of comments and nitpicks about naming.

  • generally the goal is to move more complex systems out of localstack.utils, so i would love to see the testing package moved from localstack/utils/ to localstack/ as we discussed.
  • i think it would be better to rename fixture_plugin.py and snapshot_plugin.py to fixtures.py, and snapshot.py. i don't think the _plugin adds any useful information. everything in pytest is kinda a plugin.

localstack/utils/testing/pytest/snapshot_plugin.py Outdated Show resolved Hide resolved
tests/integration/test_sts.py Show resolved Hide resolved
tests/integration/test_cloudformation.py Outdated Show resolved Hide resolved
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 13, 2022 16:54 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 13, 2022 17:00 Inactive
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dominikschubert dominikschubert merged commit a1f8c8d into master May 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
@alexrashed alexrashed deleted the test_restructure-fixtures branch June 7, 2022 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants