Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sqs query-api endpoint strategy routing #6145

Merged
merged 2 commits into from May 25, 2022
Merged

fix sqs query-api endpoint strategy routing #6145

merged 2 commits into from May 25, 2022

Conversation

thrau
Copy link
Member

@thrau thrau commented May 25, 2022

This PR fixes three issues in the query API

  • for endpoint strategy path, the queue URLs were not generated correctly, they did not have the http:// prefix
  • for endpoint strategy domain, the routing did not work because the host matching regex was matching a different scheme i had tried (sqs.<region>.localhost...), not the one we then implemented ((<region>.)queue.localhost....)
  • i reverted my decision from here bug: SQS API is not respecting the region defined in request headers #6102 (comment) and added the old behavior which was breaking other people's code.

Should fix:

@thrau thrau temporarily deployed to localstack-ext-tests May 25, 2022 17:09 Inactive
@github-actions github-actions bot added size/s aws:sqs Amazon Simple Queue Service labels May 25, 2022
dominikschubert
dominikschubert approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small potential issue in the test itself

tests/integration/test_sqs.py Show resolved Hide resolved
@thrau thrau temporarily deployed to localstack-ext-tests May 25, 2022 17:54 Inactive
@thrau thrau merged commit faf5d42 into master May 25, 2022
@thrau thrau deleted the fix-sqs-query-api branch May 25, 2022 18:25
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
aws:sqs Amazon Simple Queue Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thrau @dominikschubert