Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Events test #6239

Merged
merged 3 commits into from Jul 5, 2022
Merged

Refactor Events test #6239

merged 3 commits into from Jul 5, 2022

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Jun 8, 2022

This small PR addresses the last comment made on #5878.

Changes:

  • Test refactor for more clarity and more validations

@pinzon
Copy link
Member Author

pinzon commented Jun 19, 2022

I made the test easier to read using pytest.parametization while reviewing the feature for the last comment in #5878.

@dfangl
Copy link
Member

dfangl commented Jun 30, 2022

@pinzon It seems the test now fails in CI with the "AUTH2" parameter, can you look into it?
As a side note: we generally prefer fstrings wherever we refactor stuff, there are quite some uses of both format and % based string formatting in your changes, would be nice if you could change those to fstrings when you are fixing the test! Thanks!

@pinzon
Copy link
Member Author

pinzon commented Jun 30, 2022 •
edited

@dfangl thanks for the review!. I fixed the test and made the corrections.

dfangl
dfangl approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making the fixes!

@dfangl dfangl merged commit 8d20882 into localstack:master Jul 5, 2022
@localstack localstack locked and limited conversation to collaborators Jul 5, 2022
@pinzon pinzon deleted the ref-events-conn-test branch July 13, 2022 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pinzon @dfangl