New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix lambda ASF API updates #6411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
requested review from
dfangl,
dominikschubert and
thrau
as code owners
July 7, 2022 08:49
sorry @alexrashed ! i think #6409 created the conflict |
dominikschubert
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this 👍
alexrashed
force-pushed
the
fix-lambda-asf-api-updates
branch
from
July 7, 2022 10:33
743c23f
to
25666e1
Compare
dfangl
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since lambda is a keyword, it cannot easily be used in imports. This is why the lambda service module is called
awslambda
instead oflambda
(as the real service name is).But the scaffold's upgrade function only detects services which are named the same way as the service (with some escaping logic). This is why the generated services cannot just be renamed.
This PR fixes the scaffold to fix the automatic ASF API updates for lambda by:
awslambda
tolambda_
(which is the escaped service name).I have verified that there are no other generated APIs which have a different name than the service.
Here's the bash snippet I created to verify that: