Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set CONFIG_PROFILE correctly into config variable with localstack CLI #6636

Merged
merged 1 commit into from Aug 18, 2022

Conversation

thrau
Copy link
Member

@thrau thrau commented Aug 10, 2022

this PR modifies the localstack CLI command to correctly set the config.CONFIG_PROFILE value to whatever is passed to --profile. previously we would only set the environment variable, but the config was already loaded before the env var was set.

@thrau thrau requested a review from dfangl August 10, 2022 10:51
@thrau thrau temporarily deployed to localstack-ext-tests August 10, 2022 10:51 Inactive
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 14m 51s ⏱️ + 11m 10s
1 182 tests ±0  1 140 ✔️ ±0  42 💤 ±0  0 ±0 
1 547 runs  ±0  1 474 ✔️ ±0  73 💤 ±0  0 ±0 

Results for commit f406b9b. ± Comparison against base commit b6ef613.

@thrau thrau temporarily deployed to localstack-ext-tests August 12, 2022 17:40 Inactive
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thrau thrau merged commit 34c878d into master Aug 18, 2022
@thrau thrau deleted the set-profile-to-config branch August 18, 2022 20:32
@localstack localstack locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants