fix SNS subscription deleted when SQS endpoint was deleted #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
approved these changes
Aug 10, 2022
| snapshot.match("subscriptions-attrs-with-redrive", sub_attrs) | ||
|
|
||
| # AWS takes some time to delete the queue, which make the test fails as it delivers the message correctly | ||
| assert poll_condition(lambda: not sqs_queue_exists(queue_url), timeout=5) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the scenario where we would delete an SNS subscription (we would actually only delete the logic/publish part but not the resource in moto, which could be listed) when its SQS endpoint was deleted. It would send a message to the DLQ once if configured then delete the subscription.
AWS does not do this, it keeps the subscription and you can even set a RedrivePolicy afterwards.
I wrote a new AWS validated and snapshotted test to validate the behaviour.
There was an old PR fixing this #6160, which had a lot of merge conflicts from all the changes since.
fixes #5459