remove dead utility code #6717
Merged
remove dead utility code #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
force-pushed
the
remove-dead-code
branch
from
772d8ca
to
d0350cd
Compare
thrau
force-pushed
the
remove-dead-code
branch
from
d0350cd
to
c1087f7
Compare
thrau
requested review from
alexrashed
and removed request for
dominikschubert
alexrashed
approved these changes
Aug 26, 2022
|
thanks for the quick review @alexrashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes dead utility code. I went through the coverage report and identified code that was not covered. I then searched for usage in localstack and localstack-ext. I also removed some code that was just covered by tests but was never used elsewhere.