fix opensearch multiregion support #7237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silv-io
approved these changes
Nov 24, 2022
Yes, I actually discovered the issues when using the ES API. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an OpenSearch domain in a different region than the default one, the startup monitor failed (since it selected the wrong store, and in turn did not find the domain to change the status for). As a result, the
Processingstatus is never set tofalse(indicating that the domain creation was successful / has finished).This PR addresses this issue by:
OpensearchProvider.get_storeoutside of a request-scoped thread (i.e. the startup monitor thread).AssertionErrorin caseOpensearchProvider.get_storedoes not get an explicit region nor is run in a request-scoped thread (i.e.get_region_from_request_contextreturnsNone).